Magento 2 - hacking FedEx rate request

Question

We are running CE 2.1.2

Magento 2 sets the residential flag in the rates to request based on the configuration data. This means that all quotes are either residential or commercial, depending on what you set in the shipping method.

I want to set the flag based on if the Destination Address has a Company set or not.

What I did is go into /vendor/magento/module-fedex/Model/carrier.php and change line 430 from

'Residential' => (bool)$this->getConfigData('residence_delivery'),

to

'Residential' => !empty(trim($r->getRecipientContactCompanyName())),

The is not working. Residential is false always. So empty must be returning true always.

Is the getRecipientContactCompanyName() not the right way to get the Company name in this module? Any hints as to what I am doing wrong would be appreciated.

Answer 1

The problem is that $r is not an instance of RateRequest, it's a plain DataObject that is created in the setRequest method. You need to add

if ($request->getRecipientContactCompanyName()) {
    $r->setRecipientContactCompanyName($request->getRecipientContactCompanyName());
}

to the setRequest method before $this->setRawRequest($r);.

You should not alter the core files, instead you should override the class in a module, otherwise your changes may be lost when updating Magento.

Answer 2

At the point in the code that you are building the $r object, the $request array does not contain RecepientContactCompanyName, so getRecipientContactCompanyName() will always return FALSE.

Try pulling the Company Name from the session:

Mage::getSingleton('checkout/session')->getQuote()->getShippingAddress()->getCompany()

I have this working in 1.9.2.2 for FedEx (show Ground for commercial, Home Delivery for residential) using the following code:

In app/code/local/Mage/Usa/Model/Shipping/Carrier/Fedex.php

public function setRequest(Mage_Shipping_Model_Rate_Request $request) {
...
...
    if (Mage::getSingleton('checkout/session')->getQuote()->getShippingAddress()->getCompany()) {
        $r->setIsResidential(FALSE);
    } else {
        $r->setIsResidential(TRUE);
    }
...
...
}

protected function _formRateRequest($purpose)   {
...
...
'Recipient' => array(
    'Address' => array(
        'PostalCode'  => $r->getDestPostal(),
        'CountryCode' => $r->getDestCountry(),
        'Residential' => $r->getIsResidential()
    )
),
...
...
}