Timeline for Core/Local which is better?
Current License: CC BY-SA 3.0
9 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jul 2, 2014 at 15:07 | history | edited | Marius♦ | CC BY-SA 3.0 |
deleted 19 characters in body
|
| Jul 2, 2014 at 14:55 | comment | added | Paul Hachmang | @Marius Agreed, but think twice before rewriting the classes. Especially if you're developing a module. You could add stuff to the sales_email_order_items handle in this case (not always helpfull). | |
| Jul 2, 2014 at 14:30 | comment | added | Marius♦ | @PaulHachmang. I had to rewrite in the past the order model. Why? See the example I gave in the answer with the email template vars. | |
| Jul 2, 2014 at 14:26 | comment | added | Paul Hachmang | Also, never rewrite very important classes like the Mage_Sales_Model_Order (and invoice, etc.) classes, cart classes. Use observers exclusively here. | |
| Jul 2, 2014 at 14:25 | comment | added | Paul Hachmang | to expand: using the local code pool to override a class, will always (!) result in code dept and is by definition a dirty hack. There are some exceptions (modifying the xml config class for example) where you have no other choice. | |
| Jul 2, 2014 at 13:40 | comment | added | Marius♦ |
@TBIInfotech. I understand what you mean...that's why I added the observers approach in here also, even if you didn't mention it in the question. ON the question you linked, I think the safest way to do it is exactly how the OP answered himself. The risk is minimum. It will fall over only if the addTab method signature changes. and I doubt that.
|
|
| Jul 2, 2014 at 13:37 | comment | added | TBI Infotech | @Marius: I agree, but please check the link I shared, I guess you know what I am pointing at ;) hence i posted a question straight away (No offenses) | |
| Jul 2, 2014 at 13:33 | comment | added | kab8609 | This is the best answer ever. | |
| Jul 2, 2014 at 13:32 | history | answered | Marius♦ | CC BY-SA 3.0 |