how to get info from external url in magento2?

Question

Normally i'm using following code to get information from external url.

$url = 'http://something.net/json/' . $ipAdd;

if (!$content = file_get_contents($url)) {
  $error = error_get_last();
  $this->logger->addInfo("HTTP request failed. Error was: " . $error['message']);
  }

What is best way to get information from external url? i mean this is right way declare url and call file_get_contents function?

Answer 1

You should create your own client which follows the \Magento\Framework\HTTP\ClientInterface. Easiest way to do this is by extending the class \Magento\Framework\HTTP\Client\Curl. In your case this could look like following:

<?php
namespace Your\ModuleName\Model;

use \Magento\Framework\HTTP\Client\Curl

class Client extends Curl
{
    /**
     * Hostname
     * @var string
     */
    protected $_host = 'something.net';

    /**
     * @param string $ip
     * @return string
     */
    public function getJsonByIp($ip)
    {
        $this->get('/json/' . $ip);
        return $this->getBody();
    }
}

The usage

<?php
namespace Your\ModuleName\Model;

class MyModel
{
    /**
     * @var Client
     */
    private $client;

    /**
     * MyModel constructor.
     * @param Client $client
     */
    public function __construct(
        Client $client
    ) {
        $this->client = $client;
    }

    /**
     * @param string $ipAdd
     * @return string
     */
    public function getInfo($ipAdd)
    {
        return $this->client->getJsonByIp($ipAdd);
    }
}

Of course you should define an own interface for your client and use DI.

Answer 2

$url = 'http://something.net/json/' . $ipAdd;

You can do it using CURL functionality of php.
 $curl = curl_init();
        // Set some options - we are passing in a useragent too here
        curl_setopt_array($curl,
                           array(
                              CURLOPT_RETURNTRANSFER => 1,
                              CURLOPT_URL => $url
                           )
                         );
        // Send the request & save response to $resp
        $resp = curl_exec($curl);
        //$resp contains now json data

        // Close request to clear up some resources
        curl_close($curl);

        $jsonResponse = json_decode($resp,true);