There are a few things you can work on;
- not passing by reference, so using extra memory, you can pass objects, but arrays cannot be passed by reference by default. Or add a
& in the function parameter declaration like function hello(array &$world)
- invalid checks, if something isn't there return immediately. Do not try to find something that's not there
- readability can be hard sometimes
- add some doc (so you can understand if you see it in a few days, monhts, years)
- smarter
if statements to get less indentation
- functions should have only one purpose, update stock or update related, not both, so maybe even cut some functions in even smaller functions.
Try to create such logic in you mind, and rework from there.
- Take a look at
->cleanModelCache()->clearInstance() from Mage_Core_Model_Model_Abstract to clear underlying data for some objects, can speed up things.
- of coarse all other things which have already been said.
Added a updated version of your code with some inline recommendations on your current code, I could go on a bit, but it would currently not add more to it.
Function 1: Purpose is walking the collection
/**
* Walk collection
*
* @param Mage_Core_Model_Resource_Db_Collection_Abstract $collection
* @return void
*/
public function functionOne($collection)
{
// ...
// Walk collection, create references instead of passing array data
foreach ($collection as $item) {
// Update stock for product
if (!$this->_functionTwo($item)) {
// Not updated, continue next
continue;
}
// Update related products
$this->_functionThree($item); // Use same object again, no extra memory is used
}
// ...
}
Function 2: Purpose is updating stock if changed
/**
* Update stock item if changed, returns true if updated
*
* @param Mage_Core_Model_Model_Abstract $item
* @return bool
*/
function _functionTwo($item)
{
$model = Mage::getModel('catalog/product');
/** @var $model Mage_Catalog_Model_Product */
$id = $model->getIdBySku($item->getData('sku'));
if (!$id) {
// no id found, so stop looking nothing up
return false;
}
// Get option value for store 1
$inventoryStatus = $model->getResource()
->getAttributeRawValue($id, 'product_inventory_status', 1);
if (!$inventoryStatus) {
// No need for another lookup in db, because the status isn't set
return false;
}
$invStatus = $model->getResource()
->getAttribute('product_inventory_status')
->setStoreId(0) // Get admin value
->getSource()
->getOptionText($inventoryStatus);
if (!$invStatus) {
// No need for another lookup in db, because the status has no text
return false;
}
if ($invStatus === 'Z') {
// Inventory status to not change something
return false;
}
$stockItem = Mage::getModel('cataloginventory/stock_item');
/** @var $stockItem Mage_CatalogInventory_Model_Stock_Item */
// $stockItem->setData(array()); // unneeded piece of code
$stockItem->loadByProduct($id);
if ($stockItem->getQty() == $item->getData('quantity')) {
// Valid stock
return false;
}
// Update stock
$stockItem->setQty($item->getData('quantity'));
$stockItem->save();
// End function and call function three separately, does something else
return true;
}
Function 3: Purpose updating related stock items
/**
* Update related stock items, return false if no related items are found
*
* @param Mage_Core_Model_Model_Abstract $item
* @return bool
*/
function functionThree($item)
{
$collectionOfKits = Mage::getModel('kitinventory/kitinventory')
->getCollection()
->addFieldToFilter('related_sku', $item->getData('sku')); // Check if your indexes are set on these columns
if (!$collectionOfKits->getSize()) {
// Nothing found to relate to
return false;
}
$connection = Mage::getSingleton('core/resource')
->getConnection('core_write');
// Walk kits
foreach ($collectionOfKits as $kit) {
// getData is slightly faster then getSku(unless you've implemented it in your model)
// getSku -> __call('getSku') -> get -> lowercase('sku') -> getData('sku') | note, Magento has some internal caching in this
$kitSku = $kit->getData('sku');
$kitCollection = Mage::getModel('kitinventory/kitinventory')
->getCollection()
->addFieldToFilter('kit_sku', $kitSku)
->setOrder('related_sku', 'ASC');
// Use just a fetchAll to create a fast db query
$select = $kitCollection->getSelect();
$select->reset(Zend_Db_Select::COLUMNS)
->distinct()
->columns('related_sku')
->columns('required_quantity');
// Fetch component sku
$componentSkus = $connection->fetchAll($select, 0);
// Fetch required quantity
$componentRequiredQuantity = $connection->fetchCol($select, 1);
// ...
$componentProductCollection = Mage::getModel('catalog/product')
->getCollection()
->joinField('qty',
'cataloginventory/stock_item',
'qty',
'product_id = entity_id',
'{{table}}.stock_id = 1',
'left');
$componentProductCollection->addAttributeToFilter('sku', array('in' => $componentSkus));
// Next line will invoke a load on the product collection
foreach ($componentProductCollection as $component) {
$quantity = $component->getQty();
// ...
}
// You could choose to do a fetchAll here instead to get just the data you need
$connection = $componentProductCollection->getConnection();
foreach ($connection->fetchAll($componentProductCollection->getSelect()) as $row) {
// Will have a array here
$quantity = $row['quantity'];
// ... -- do not not which funky magic happens here
}
$kitId = Mage::getModel('catalog/product')
->getIdBySku($kitSku);
if (!$kitId) {
// No id
continue;
}
// You could also take a look if you can sum the stock and do a single update instead
$kitStockItem = Mage::getModel('cataloginventory/stock_item')
->loadByProduct($kitId);
$this->functionFour($kitStockItem, $kitSku, $amountOfKitsPossible);
// Or something like this, update single field
$connection->update($kitStockItem->getResource()->getMainTable(), array('qty' => $quantity), 'item_id = ' . $kitStockItem->getId());
}
return true;
}
Function 4: Had to make some lucky(or unlucky) guesses, for now it is a useless function, could be added as is in Function 3.
/**
* Save stock item if changed and something else, rather not say ;-)
*
* @param Mage_Catalog_Inventory_Model_Stock_Item $kitStockItem
* @param string $kitSku
* @param int $amountOfKitsPossible Guessed it
*/
function functionFour($kitStockItem, $kitSku, $amountOfKitsPossible)
{
// ...
// Do not know the rest of the code, so I wouldn't know which I could optimize here
// If it isn't to serious, you could look at a single query and not hitting extra functions
// Check if changed
if ($quantity !=$kitStockItem->getData('qty')) {
$kitStockItem->setQty($quantity);
$kitStockItem->save();
}
// ...
}
}
functionOne($collection)? In what order would it's size/count of items be? Is it necessary to loop over it to get the SKU's?