I just was examining the PATCH_SUPEE-3941_EE_1.14.0.1_v1.sh (download page) which changes downloader/lib/Mage/Connect/Packager.php file and noticed that there is a strange lines:

enter image description here

Is this a dev typo? Why do we need 2 identical lines? Additionally I have submitted a bug report.

  • Be careful with this screenshot, you are not allowed to share this :( Oct 22 '14 at 18:06
  • Why not? I can provide it as text, but I suppose it would look better in diff view. Oct 23 '14 at 6:46
  • 1
    Sorry. Misunderstanding. It is magentos copyright and they don't allow you to share patches. Oct 23 '14 at 8:00

I think you are right. They deleted the wrong line. It doesn't make sense to remove the dir creation and instead have two lines setting $source.

Let's see what they answer on the ticket.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.