Magento debug trace

Question

When i enabled query logging in magento from ADD TO CART till the cart page completes loading, it actually gave me same queries repeating 30-40 times.Not all queries but some of them so i decided to trace it by enabling

protected $_logCallStack        = true;

To my surprise the repeating queries in the query log are actually giving same trace details with small diff in some encoded chara for eg:

#9 Mage_SalesRule_Model_Rule_Condition_Product_Subselect#000000000a8f1b7500000000689133ef#->validate(&GoMage_Checkout_Model_Quote_Address#000000000a8f1bcd00000000689133ef#) called at [app/code/core/Mage/Rule/Model/Condition/Combine.php:251]

#9 Mage_SalesRule_Model_Rule_Condition_Product_Subselect#000000000a8f189300000000689133ef#->validate(&GoMage_Checkout_Model_Quote_Address#000000000a8f1bcd00000000689133ef#) called at [app/code/core/Mage/Rule/Model/Condition/Combine.php:251]

I am not understanding why the queries are repeatedly coming in my trace and why the same sequence of code is actually executing more than once and firing same queries repeatedly.

Or the tracing mechanism of magento is giving me wrong output?? Have anybody experienced this before.

Answer 1

For those using Enterprise 1.14.1 and have a sales rule with a subselection of categories, I ran into the OPs issue with an infinite loop. I'm not sure what version the OP is using, but this may be the problem.

In: Mage_SalesRule_Model_Rule_Condition_Product_Combine::validate(), there is call to check the child products if the product in play is configurable; if invalid, it will check the children:

        $valid = $children && $this->validate($children[0]);

The problem is that $this refers to Mage_SalesRule_Model_Rule_Condition_Product_Subselect. Notice in the validate method within this class, we have:

    foreach ($object->getQuote()->getAllVisibleItems() as $item) {
        if (parent::validate($item)) {
            $total += $item->getData($attr);
        }
    }

Well, that's a problem! The Visible Quote Items will be retrieved over and over and the parent method will continue to call the configurable item. This Mage_SalesRule_Model_Rule_Condition_Product_Subselect::validate will never run on the child object so we have an infinite loop and nobody will be able to add or view the cart.

To fix, I changed:

$valid = $children && $this->validate($children[0]); to $valid = $children && self::validate($children[0]);

This allows the Mage_SalesRule_Model_Rule_Condition_Product_Combine::validate method to run on the child products, as it should.

Update 11/21/2014

Magento just provided a patch for this as PATCH_SUPEE-4814_EE_1.14.1.0_v1.sh Changes are in: app/code/core/Mage/SalesRule/Model/Rule/Condition/Product/Subselect.php on line 114:

From:

if (parent::validate($item)) {

To:

if (Mage_Rule_Model_Condition_Combine::validate($item)) {