0

I want to make a single line change in the constructor of a core class. What would be the best recommended practice to achieve it.

Here is what my existing constructor

/**
     * Download constructor.
     *
     * @param Context $context
     * @param Filesystem $filesystem
     * @param FileFactory $fileFactory
     */
    public function __construct(
        Context $context,
        Filesystem $filesystem,
        FileFactory $fileFactory
    ) {
        $this->fileFactory = $fileFactory;
        $this->directory = $filesystem->getDirectoryRead(DirectoryList::LOG);

        parent::__construct($context);
    }

and I want to change it like this

/**
     * Download constructor.
     *
     * @param Context $context
     * @param Filesystem $filesystem
     * @param FileFactory $fileFactory
     */
    public function __construct(
        Context $context,
        Filesystem $filesystem,
        FileFactory $fileFactory
    ) {
        $this->fileFactory = $fileFactory;
        $this->directory = $filesystem->getDirectoryRead(DirectoryList::**VAR_DIR**);

        parent::__construct($context);
    }

Should I use preference for this?

0

1 Answer 1

1

Check below code and use as per your requirement.

Create a new class that extends the original class and overrides the constructor.

<?php

namespace Your\Module\Model;

use Magento\Framework\Model\AbstractModel;

class MyModel extends AbstractModel
{
    protected $dependency;

    public function __construct(
        //Inject the original constructors dependency
        \Magento\Framework\Model\Context $context,
        \Magento\Framework\Registry $registry,
        // Add new dependency
        \My\Dependency\Class $dependency,
        array $data = []
    ) {
        parent::__construct($context, $registry, $data);
        // Use the new dependency
        $this->dependency = $dependency;
    }
}

Define a new preference for your class in a di.xml file. This file should be located in app/code/Your/Module/etc/di.xml

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
    <preference for="Magento\Framework\Model\AbstractModel" type="Your\Module\Model\MyModel" />
</config>

In this example, we have added a new dependency \My\Dependency\Class to the constructor of the original class Magento\Framework\Model\AbstractModel and created a new class Your\Module\Model\MyModel that extends the original class and overrides its constructor.

In the di.xml file, we have defined a preference for the original class and specified that our new class should be used instead.

UPDATED

Here is an example of how to use override the __construct property using plugin:

Setp 1 :- Create etc/di.xml file.

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
    <type name="Vendor\Module\Model\YourClass">
        <plugin name="your_plugin_name" type="Vendor\Module\Plugin\YourPlugin" sortOrder="1" />
    </type>
</config>

Step 2 :- Now Create plugin in this path Plugin\YourPlugin.php

<?php
        
namespace Vendor\Module\Plugin;

use Closure;
use Vendor\Module\Model\YourClass;

class YourPlugin
{
    public function __construct(
        // You want to override constructor parameter here
    ) {
        // You want to override constructor parameter here
    }

    public function aroundYouWantFunction(YourClass $subject, Closure $proceed)
    {
        // Do something before the original __construct method is called
        // ...

        // Call the original __construct method
        $proceed();

        // Do something after the original __construct method is called
        // ...
    }
}

  

Let me know if any query.

THANKS.

4
  • Than you Mohit for your answer, I have already done it by using preferences, I was asking, is there any other way to override the constructor without using preference? Commented Jan 13, 2023 at 18:13
  • So you want to override using plugin? Commented Jan 16, 2023 at 7:19
  • yes in other words, because plugin is a better way than preferences. But there is a limitation in plugin that we can not use for constructor. Commented Jan 17, 2023 at 9:37
  • I have update the code please check and let me know if any query. Commented Jan 17, 2023 at 10:05

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Not the answer you're looking for? Browse other questions tagged or ask your own question.