I could successfully follow the instructions to install the latest security patches on our Magento store running on community version 2.4.2. I'm not sure if patches really installed well because I find only a few files modified as the screenshot below shows. Kindly confirm if everything went well with the install.
1 Answer
waaaait, do You really keep vendor content in Your project Repo?
It is not really a good idea. Vendor catalog should be added to .gtignore.
You should manage packages via files compsoer.json and composer.lock.
Vendor should be installed on Server with composer install
command. In that case adding patches would be super simple - by adding one or two more lines to Your composer.json
HOWEVER, answering Your question, look like Patches were installed correctly. I mean, at least files related to patches were modified.
-
Thanks Konrad for the additional helpful tips on the vendor thing. Yes, we put everything within vendor in the the git repository. I will consider discussing this with my manager to see what he says. Feb 21, 2022 at 12:55
-
-
Konrad, is it necessary to check in all those untracked files and a directory too? Please let me know what you think. Feb 23, 2022 at 6:40
-
hey, I am not using skype. What do You mean by
to check in
all untracked files? Just changes related to PATCH? It is hard to tell. I dont know right now which files are untracked for Your project. However, Magento Patches should modify only Magento core files - or files from related modules in vendor. Also, You can just open PATCH and verify change files and changes in files. You can also compare it with current status. Feb 23, 2022 at 7:24 -
Thanks Konrad. When I say check in, I thought it means checking them into git repository. Feb 23, 2022 at 7:29