Magento 2 - overriden class extending overriden class not working

Question

I have overriden the class Magento\Catalog\Block\Product\ProductList\Upsell with my own Company\Base\Block\Product\ProductList\Upsell.

The class Magento\Catalog\Block\Product\ProductList\Upsell extends \Magento\Catalog\Block\Product\AbstractProduct.

Now I have overridden \Magento\Catalog\Block\Product\AbstractProduct with \Company\Base\Block\Product\AbstractProduct and added a new method:

public function testAbstractMethod()
{
    echo "test abstract works";
}

I added

<?php exit($this->testAbstractMethod()) ?>

to the template of the class Magento\Catalog\Block\Product\ProductList\Upsell:

app\design\frontend\MyTheme\Base\Magento_Catalog\templates\product\list\items.phtml:

But I get:

Invalid method Company\Base\Block\Product\ProductList\Related\Interceptor::testAbstractMethod

But if I add the method testAbstractMethod() to the original core class \Magento\Catalog\Block\Product\AbstractProduct then it works.

So it looks like only the first class is getting overriden and if this class extends another class which is overriden by dependency injection, then it wont work and load the original class?

Answer 1

I would suggest you to simplify the solution. You should do the changes in one class and not override the abstract unless really necessary. You can still override the method from the abstract class in your new class.

Answer 2

You can't override abstract classes in Magento. You should try with a plugin: https://devdocs.magento.com/guides/v2.3/extension-dev-guide/plugins.html

EDIT: I got it! you have to rename the method. It MUST start with one of: get, set, uns or has

So if you rename your method like this:

    public function getTestAbstractMethod()
    {
        echo "test abstract works";
    }

Will work.

Your exception is thrown in: \Magento\Framework\DataObject::__call

     * Set/Get attribute wrapper
     *
     * @param   string $method
     * @param   array $args
     * @return  mixed
     * @throws \Magento\Framework\Exception\LocalizedException
     */
    public function __call($method, $args)
    {
        switch (substr($method, 0, 3)) {
            case 'get':
                $key = $this->_underscore(substr($method, 3));
                $index = isset($args[0]) ? $args[0] : null;
                return $this->getData($key, $index);
            case 'set':
                $key = $this->_underscore(substr($method, 3));
                $value = isset($args[0]) ? $args[0] : null;
                return $this->setData($key, $value);
            case 'uns':
                $key = $this->_underscore(substr($method, 3));
                return $this->unsetData($key);
            case 'has':
                $key = $this->_underscore(substr($method, 3));
                return isset($this->_data[$key]);
        }
        throw new \Magento\Framework\Exception\LocalizedException(
            new \Magento\Framework\Phrase('Invalid method %1::%2', [get_class($this), $method])
        );
    }

Magento's magic :D