Unable to redirect to cart page from observer?

Question

Here is the code, please review and advise.

Demo/Test/etc/frontend/events.xml

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
    <event name="layout_generate_blocks_before">
        <observer name="Demo_check_for_vision_user_session" instance="Demo\Test\Observer\CheckForTestUserSession" />
    </event>    
</config>

Demo/Test/Observer/CheckForTestUserSession.php

<?php

namespace Demo\Test\Observer;

use Psr\Log\LoggerInterface;
use Magento\Framework\Event\Observer;
use Magento\Framework\Event\ObserverInterface;
use Magento\Framework\Session\SessionManagerInterface;
use Magento\Framework\App\Request\Http;
use Magento\Framework\UrlInterface;
use Magento\Framework\App\ResponseFactory;
use Magento\Framework\App\Response\RedirectInterface;
/**
 * Class CheckForTestUserSession
 * @package Demo\Test\Observer
 */
class CheckForTestUserSession implements ObserverInterface
{
    /**
     * @var SessionManagerInterface
     */
    private $coreSession;

    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * @var Http
    */
    protected $request;

    /**
    * @var UrlInterface
    */
    protected $url;

    /**
    * @var ResponseFactory
    */
    protected $responseFactory;

    /**
    * @var RedirectInterface
    */
    protected $redirect;



    /**
     * constructor
     */
    public function __construct(
        LoggerInterface $logger,
        SessionManagerInterface $coreSession,
        Http $request,
        UrlInterface $url,
        ResponseFactory $responseFactory,
        RedirectInterface $redirect

    ) {
        $this->logger = $logger;
        $this->coreSession = $coreSession;
        $this->request = $request;
        $this->url=$url;
        $this->responseFactory = $responseFactory;
        $this->redirect = $redirect;

    }

    /**
     * Vision redirects a customer
     *
     * @param Observer $observer
     */
    public function execute(Observer $observer)
    {
        $action = $observer->getEvent()->getFullActionName();
        $SID= $this->request->getParam('SID');
        //$layout = $observer->getEvent()->getLayout();
        //$custId = $this->getRequest()->getParam('id');
        $writer = new \Zend\Log\Writer\Stream(BP.'/var/log/magento11.log');
        $logger = new \Zend\Log\Logger();
        $logger->addWriter($writer);
        if($SID){       

        $controller = $observer->getControllerAction();
        $this->redirect->redirect($controller->getResponse(), 'checkout/cart');        
        }        
    }


}

Answer 1

I am not sure why you are using "layout_generate_blocks_before" event to redirect to cart if current URL contains SID param. You can create a router file using following way.

etc/frontend/di.xml

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
    <type name="Magento\Framework\App\RouterList">
        <arguments>
            <argument name="routerList" xsi:type="array">
                <item name="redirect_if_sid" xsi:type="array">
                    <item name="class" xsi:type="string">Demo\Test\Controller\Router\RewriteSID</item>
                    <item name="disable" xsi:type="boolean">false</item>
                    <item name="sortOrder" xsi:type="string">20</item>
                </item>
            </argument>
        </arguments>
    </type>
</config>

Controller/Router/RewriteSID.php

<?php

namespace Demo\Test\Controller\Router;

class RewriteSID implements \Magento\Framework\App\RouterInterface
{
    protected $actionFactory;
    protected $_response;
    protected $storeManager;

    public function __construct(
        \Magento\Framework\App\ActionFactory $actionFactory,
        \Magento\Framework\App\ResponseInterface $response,
        \Magento\Store\Model\StoreManagerInterface $storeManager
    ) {
        $this->actionFactory = $actionFactory;
        $this->_response = $response;
        $this->storeManager = $storeManager;
    }

    public function match(\Magento\Framework\App\RequestInterface $request)
    {
        $identifier = $request->getOriginalPathInfo();

        $condition = new \Magento\Framework\DataObject(['identifier' => $identifier, 'continue' => true]);
        $identifier = $condition->getIdentifier();

        if ($condition->getRedirectUrl()) {
            $this->_response->setRedirect($condition->getRedirectUrl());
            $request->setDispatched(true);
            return $this->actionFactory->create('Magento\Framework\App\Action\Redirect');
        }

        if (!$condition->getContinue()) {
            return null;
        }

        if ($request->getParam('SID')) {
            $redirect_url = $this->storeManager->getStore()->getUrl('checkout/cart/index');
        }
        else
        {
            return null;
        }

        $this->_response->setRedirect($redirect_url);
        $request->setDispatched(true);
        return $this->actionFactory->create('Magento\Framework\App\Action\Redirect');
    }
}

This will redirect any url to shopping cart page if URL is somewhat as below.

http://yourdomain.com/anyurl/?SID=1

Try this and i guess it can perform the same result.

Answer 2

You can change you Observer's code with below code

<?php

namespace Demo\Test\Observer;

use Psr\Log\LoggerInterface;
use Magento\Framework\Event\Observer;
use Magento\Framework\Event\ObserverInterface;
use Magento\Framework\Session\SessionManagerInterface;
use Magento\Framework\App\Request\Http;
use Magento\Framework\UrlInterface;
use Magento\Framework\App\ResponseFactory;
use Magento\Framework\App\Response\RedirectInterface;
/**
 * Class CheckForTestUserSession
 * @package Demo\Test\Observer
 */
class CheckForTestUserSession implements ObserverInterface
{
    /**
     * @var SessionManagerInterface
     */
    private $coreSession;

    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * @var Http
    */
    protected $request;

    /**
    * @var UrlInterface
    */
    protected $url;

    /**
    * @var ResponseFactory
    */
    protected $responseFactory;

    /**
    * @var RedirectInterface
    */
    protected $redirect;

    protected $_actionFlag;

    /**
     * constructor
     */
    public function __construct(
        LoggerInterface $logger,
        SessionManagerInterface $coreSession,
        Http $request,
        UrlInterface $url,
        ResponseFactory $responseFactory,
        RedirectInterface $redirect,
        \Magento\Framework\App\ActionFlag $actionFlag
    ) {
        $this->logger = $logger;
        $this->coreSession = $coreSession;
        $this->request = $request;
        $this->url=$url;
        $this->responseFactory = $responseFactory;
        $this->redirect = $redirect;
        $this->_actionFlag = $actionFlag;
    }

    /**
     * Vision redirects a customer
     *
     * @param Observer $observer
     */
    public function execute(Observer $observer)
    {
        $action = $observer->getEvent()->getFullActionName();
        $SID= $this->request->getParam('SID');
        //$layout = $observer->getEvent()->getLayout();
        //$custId = $this->getRequest()->getParam('id');
        $writer = new \Zend\Log\Writer\Stream(BP.'/var/log/magento11.log');
        $logger = new \Zend\Log\Logger();
        $logger->addWriter($writer);
        if($SID){       

        $controller = $observer->getControllerAction();
        $this->_actionFlag->set('', \Magento\Framework\App\Action\Action::FLAG_NO_DISPATCH, true);
        $this->_redirect->redirect($controller->getResponse(), 'customer/account/create');
        }        
    }
}

I've added this line in your observer

$this->_actionFlag->set('', \Magento\Framework\App\Action\Action::FLAG_NO_DISPATCH, true);

Hope this will help you!

Answer 3

$redirectionUrl = $this->url->getUrl('checkout/cart');
$this->responseFactory->create()->setRedirect($redirectionUrl)->sendResponse();