Magento shoping cart price rule in EE 1.14

Question

I am working on magento shop having Enterprise 1.14, In my old shop which is based on magento CE 1.81, there is shopping cart price rule to buy x items and get y free.

After up gradation to EE 1.14, this rule applies only on first item of cart out of z items meeting the criteria. In my rule definition I have set stop further processing to Yes and rule's priority is 0 which mean this rule should run on each item of cart and stop to affect any other rule but it works only first item of cart and then nothing.

When I dig into code, I saw they have below code in foreach loop at line 317 of Mage_SalesRule_Model_Validator model.

if ($this->_stopFurtherRules) {
            break;
        }

In release notes of Magento CE 1.9 and EE 1.14, they have mentioned that

The setting Stop Further Rules Processing is honored.

so my question is, what does mean of **The setting Stop Further Rules Processing is honored. **?

Have they changed the meaning of Stop Further Rules Processing or is it bug in magento CE 1.9 and EE 1.14?

Answer 1

Though this is not answer of question. I still don't know why they have written code like this but below is my patch to make it work as in older version.

I override Mage_SalesRule_Model_Validator model and overload process function.

public function process(Mage_Sales_Model_Quote_Item_Abstract $item){
     $this->_stopFurtherRules = false;
     parent::process($item)
}

so now a matched rule will run on all cart items instead of first one only.

May be it is helpful for someone :)

Answer 2

Stop Further Rules Processing

This means that once the first rule match occurs that no other rules will be matched. I would use this flag to limit the amount of cart prices at can effect a single user.

Say if you have one 20% discount for condition x and then another 20% discount for condition y.

If the users cart matches condition x and y you can use this filter to stop both discounts being applied.