Magento 2 Integration Tests issue for custom attributes

Question

I have created 2 new product attributes that are mandatory (required), "vendor_id" and "delivery_country".

After creating this two attributes the integration tests are failing.

I executed the testes just for one module to see what is happening:

<directory suffix="Test.php">testsuite/Magento/AdvancedCheckout</directory>

When running the integrations tests for this module it gives me fatal error:

Magento\AdvancedCheckout\Controller\CartTest::testConfigureFailedActionWithDownloadableProduct

Magento\Eav\Model\Entity\Attribute\Exception: The value of attribute "vendor_id" must be set in /vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:111

I have noticed that this module is using this two files for products:

dev/tests/integration/testsuite/Magento/Downloadable/_files/product_downloadable.php

and

dev/tests/integration/testsuite/Magento/Catalog/_files/product_simple.php

I added the new attributes in the above files, after executing tests again they are passing.

The problem is that there are many files that are creating products for integration tests and I don't see as a solution to modify this files.

Is there a way to set this new attributes on all the products that are created for integration tests without modifying all the fixture files.

Answer 1

You cannot run the core test suite with a customized build like this. But this is not their purpose anyways. The core integration test suite is there to ensure that the core modules work together as intended and to prevent bugs in Magento itself.

If you want to run an integration test for the checkout that is adapted to your changes, you are free to reuse parts of the core tests, but you will have to make adjustments like adding values for custom required attributes in the used fixtures.

But do not try to recreate integration tests just for core functionality. Create tests that ensure, that your code works.

For high level "Magento still works" tests, functional tests are more appropiate than integration tests. That's also why the new Magento Functional Test Framework (MFTF) will give us extensible core tests. This one is meant to be run on custom builds.

Answer 2

This above error means your fixture files are not loading at the time when your test runs or db is not isolated, In my opinion you can give try by doing following steps :

rootdir\dev\tests\integration\phpunit.xml.dist rename to phpunit.xml add following code

<testsuite name="Third Party Integration Tests">
            <directory>../../../app/code/*/*/Test/Integration</directory>
            <directory>../../../vendor/*/module-*/Test/Integration</directory>
            <exclude>../../../app/code/Magento</exclude>
            <exclude>../../../vendor/magento</exclude>
        </testsuite>

Then your Integration test location should be rootdir/app/code/Vendor/ModuleName/Tests/Integration/

Open Terminal Run command from magento root directory :

cd dev/tests/integration 

php ../../../vendor/bin/phpunit --testsuite "Third Party Integration Tests"

Make Sure following annotation definition in your test Chckout this link for better understanding

In my opinion you need to isolate your db before runing the test and define the value of custom attribute in fixture file and loadFixture , Also make sure your fixture file is running and taking a correct value .Take a look on following example :

Integration test file :

Class XYZTest extends \PHPUnit\Framework\TestCase
{

 public static function loadFixture()
    {
        include __DIR__ . '/../_files/product_downloadable_create_with_setting_custom_attribute_value.php';

   /**
     * @magentoDbIsolation enabled
     * @magentoAppIsolation enabled
     * @magentoDataFixture loadFixture
     */
    public function testYourFunctionName()
    {
      //use above annotation as per your need 
      .................
      .......................
    }

    }
}

Hopefully this will help you .